From 2adeb4addd2230b1173abe47ad17c1b321099f19 Mon Sep 17 00:00:00 2001 From: Alexey Shalaev <75322386+AlexeyShalaev@users.noreply.github.com> Date: Sun, 18 Oct 2026 01:31:23 +0400 Subject: [PATCH] fix: setup_repo.py keeps the repository name after the release App check The loop over the App's variable and secret reused `name`, the repository name, as its loop variable. After it, the Trusted Publisher hint printed RELEASE_PLEASE_APP_PRIVATE_KEY as the project and the repository, and a repository with Pages and no homepage would get https://.github.io/RELEASE_PLEASE_APP_PRIVATE_KEY/ as its homepage. --- scripts/setup_repo.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/setup_repo.py b/scripts/setup_repo.py index f5944ca..856a56d 100644 --- a/scripts/setup_repo.py +++ b/scripts/setup_repo.py @@ -124,9 +124,9 @@ def visible(kind: str) -> set[str]: names.update(item["name"] for item in listed.get(kind, [])) return names - for kind, name in (("variables", RELEASE_APP_CLIENT_ID), ("secrets", RELEASE_APP_PRIVATE_KEY)): - if name not in visible(kind): - print(f" [WARN] Actions {kind[:-1]} {name} is not visible to {repo}: CI will not run on" + for kind, setting in (("variables", RELEASE_APP_CLIENT_ID), ("secrets", RELEASE_APP_PRIVATE_KEY)): + if setting not in visible(kind): + print(f" [WARN] Actions {kind[:-1]} {setting} is not visible to {repo}: CI will not run on" " release PRs until it is (template README, 'The release App')") step("Actions: workflows get a read-only token unless they ask for more; Release Please may open PRs")