From 59a3aaabe2201a8587cb93bb8d1e7f44e602bc6d Mon Sep 17 00:00:00 2001 From: Vaibhav Gogte CA Date: Mon, 2 Nov 2026 13:27:29 -0800 Subject: [PATCH] Revert: Adding an ablation study for understanding the performance trade-offs of using a shorter demand cycle. PiperOrigin-RevId: 1012407659 --- tcmalloc/experiment_config.h | 2 -- tcmalloc/parameters.cc | 14 -------------- 2 files changed, 16 deletions(-) diff --git a/tcmalloc/experiment_config.h b/tcmalloc/experiment_config.h index d6d0a004b..7acab0b7d 100644 --- a/tcmalloc/experiment_config.h +++ b/tcmalloc/experiment_config.h @@ -24,7 +24,6 @@ enum class Experiment : int { // clang-format off // go/keep-sorted start TCMALLOC_CFL_PRIORITIZATION_ABLATION, // TODO: b/567166830 - Complete experiment. - TCMALLOC_DEMAND_CYCLE_120S, // TODO: b/540987155 - Complete experiment. TCMALLOC_PGHO_EXPERIMENT, // TODO: b/460486507 - Complete experiment. TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION, // TODO: b/205153285 - Complete experiment. TCMALLOC_RELEASE_FREE_STALE, // TODO: b/527473378 - Complete experiment. @@ -58,7 +57,6 @@ struct ExperimentConfig { inline constexpr ExperimentConfig experiments[] = { // go/keep-sorted start {Experiment::TCMALLOC_CFL_PRIORITIZATION_ABLATION, "TCMALLOC_CFL_PRIORITIZATION_ABLATION"}, - {Experiment::TCMALLOC_DEMAND_CYCLE_120S, "TCMALLOC_DEMAND_CYCLE_120S"}, {Experiment::TCMALLOC_PGHO_EXPERIMENT, "TCMALLOC_PGHO_EXPERIMENT"}, {Experiment::TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION, "TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION"}, {Experiment::TCMALLOC_RELEASE_FREE_STALE, "TCMALLOC_RELEASE_FREE_STALE"}, diff --git a/tcmalloc/parameters.cc b/tcmalloc/parameters.cc index 55e032e41..3dbf77168 100644 --- a/tcmalloc/parameters.cc +++ b/tcmalloc/parameters.cc @@ -126,20 +126,6 @@ static std::atomic& hpaa_subrelease_ptr() { } void Parameters::InitializeFromExperiments() { -#if !defined(TCMALLOC_INTERNAL_SMALL_BUT_SLOW) - if (IsExperimentActive(Experiment::TCMALLOC_DEMAND_CYCLE_120S)) { - skip_subrelease_short_interval_ns_.store( - absl::ToInt64Nanoseconds(absl::Seconds(60)), std::memory_order_relaxed); - skip_subrelease_long_interval_ns_.store( - absl::ToInt64Nanoseconds(absl::Seconds(300)), - std::memory_order_relaxed); - skip_subrelease_cold_short_interval_ns_.store( - absl::ToInt64Nanoseconds(absl::Seconds(60)), std::memory_order_relaxed); - skip_subrelease_cold_long_interval_ns_.store( - absl::ToInt64Nanoseconds(absl::Seconds(300)), - std::memory_order_relaxed); - } -#endif if (IsExperimentActive(Experiment::TCMALLOC_SONIC_TRACK_BROKEN_HUGEPAGES)) { track_broken_hugepages_.store(TrackBrokenHugepages::kEnabled,