Repository navigation
TI-4036: Rename external choice identifiers to external_key - #26
Merged
Merged
Conversation
Joel-Luca
force-pushed
the
fix/ti-4036-external-key
branch
from
September 23, 2026 13:46
12a2d3b to
9c4b7a0
Compare
all4manu
approved these changes
Sep 24, 2026
Joel-Luca
force-pushed
the
fix/ti-4036-external-key
branch
from
September 24, 2026 09:16
9c4b7a0 to
1a00597
Compare
Joel-Luca
force-pushed
the
fix/ti-4036-external-key
branch
from
September 24, 2026 09:47
1a00597 to
dd13dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the untranslated custom-value
external_labelfield toexternal_keyso its purpose as a stable external identifier is explicit.ChoiceMatcher(choices)now matches exact external keys by default; generic label/value matching remains available explicitly.Update the example app, admin, translations and upgrade documentation. A reversible example migration preserves existing keys/values and replaces the field-scoped uniqueness constraint. Every concrete consumer needs its own corresponding migration before upgraded workers start. This supports RIS PRs #4133 and #4140; no package release is published here.
Validation: 220 custom-field tests passed; the rename migration round trip passed; the final matching-contract rerun passed 119 tests.
makemigrations --check --dry-run, Black, isort and gettext compilation passed. Full CI was not run.Tracking: TI-4036.