Repository navigation
Keep the dev profile argument whole when no version is given - #20
Merged
Merged
Conversation
The integration and performance scripts build the examples with the dev profile when the workflow passes no version, as the pull request run does. PowerShell unrolled the one element array holding that argument into a string, and splatting a string hands Maven each character, so Maven saw a lifecycle phase called -. The variable is now typed as a string array, so the argument reaches Maven whole. The publish run passes a version and was not affected.
ben51degrees
marked this pull request as ready for review
November 2, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pull Requests run failed at the Selenium contract step with Maven reporting an unknown lifecycle phase called -.
Cause
The integration and performance scripts build the examples with the dev profile when the workflow passes no version, which is what the pull request run does. The argument was held in a one element array, PowerShell unrolls such an array returned from an if expression into a plain string, and splatting a string hands a native command each character. Maven received - P d e v. The publish run passes a version, so its two element array stayed an array and was never affected.
Change
The variable is typed as a string array in both scripts, so the single argument reaches Maven whole. Nothing else changes.
What was checked
A PowerShell check of both forms against a native command: the untyped form passes the characters separately, the typed form passes -Pdev whole. Both scripts parse. The next Pull Requests run is the check on the runners.