Skip to content

Drop the macOS x64 Java 8 configuration, which had no JDK 8 - #21

Merged
ben51degrees merged 1 commit into
mainfrom
ci/drop-the-macos-x64-java-8-configuration
Nov 2, 2026
Merged

ben51degrees merged 1 commit into
mainfrom
ci/drop-the-macos-x64-java-8-configuration

Conversation

@ben51degrees

Copy link
Copy Markdown
Contributor

The Pull Requests run failed on MacOS_X64_Java_8 compiling the Pipeline API's 51Did module: a Javadoc comment in the OWID submodule is attached to no declaration, the JDK in use reports that under -Xlint:all, and the tree compiles with -Werror.

Cause

The macos-15 image provides no JDK 8, so JAVA_HOME_8_X64 is empty there and the job ran on the runner's default JDK, which is now 25 and has lint rules older JDKs do not. The configuration came from the Device Detection repository's matrix, where it never compiled that module, and it has never tested Java 8 at all.

Change

The configuration is removed from ci/options.json. Java 8 stays tested on Ubuntu and Windows, and macOS x64 keeps Java 11, 17 and 21, which the image provides and which the dry run passed on.

What was checked

The file still loads as JSON with 15 configurations. The next Pull Requests run is the check on the runners.

The macos-15 image provides no JDK 8, so that configuration ran on the
runner's default JDK, lately 25, whose lint rules fail the Pipeline API
build under -Werror. Java 8 is still tested on Ubuntu and Windows, and
macOS x64 keeps Java 11, 17 and 21, which the image provides.
@ben51degrees
ben51degrees marked this pull request as ready for review November 2, 2026 20:57
@ben51degrees
ben51degrees merged commit 3df4902 into main Nov 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant