Repository navigation
Let the web examples find their folder and their data from wherever they run - #7
Merged
Merged
Conversation
…hey run The two Device Detection web examples handed Jetty their webapp folder as a path relative to the working directory, so starting them from inside examples/device-detection, as the Selenium contract run does, doubled the path and Jetty served nothing. They now resolve the folder by searching, as their tests already did. The example configurations' default data file paths pointed at the data folders as they were in the separate repositories. They now point at the folders inside the cxx submodule, so an example run from the repository root finds the free data file without being told where it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rerun of the Publish dry run passed every Maven test on every platform and then failed the Selenium contract tests on the six x64 and macOS jobs: all nine cases timed out with the page loaded but the core script never defined.
Cause
The earlier change that named the Device Detection web examples' webapp folder in full fixed the test, which resolves the folder by searching, but the examples' own main method hands that folder to Jetty as a path relative to the working directory. The contract run starts the jar from inside examples/device-detection, so Jetty got examples/device-detection/examples/device-detection/... and served an empty application. The Jetty log line in the job shows exactly that doubled path.
Changes
What was checked