Repository navigation
Expect the default data file path inside cxx in the data file option test - #8
Merged
Merged
Conversation
…test The on-premise web example's configuration defaults to the Lite data file inside the cxx submodule, and the test that checks the default still expected the old location.
ben51degrees
marked this pull request as ready for review
November 2, 2026 18:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest rerun of the Publish dry run passes the Selenium contract tests, nine of nine, on the Ubuntu jobs. One unit test still fails: OnPremDataFileOptionTest checks the default data file path in the on-premise web example's configuration and expected device-detection-data/51Degrees-LiteV4.1.hash, while the default now points inside the cxx submodule.
The test expects the new path. Nothing else changes.
What was checked
The test module was run here against the reactor artifacts: 3 tests, 0 failures.