Repository navigation
Move to CEF Browser Engine - #247
Merged
Merged
Conversation
- The opener takes the parent window as text, main.cpp gets it from the window
- Chromium moves the process into app-org.chromium.Chromium-<pid>.scope, the portal would attribute the calls to it - A connection of the opener's own, so the registration is its first portal call
- NUI_SFTP_MACOS followed BROWSER_ENGINE=wkwebview, a macOS frontend for Chromium needs it as well
- Nui gains the CEF engine (NUI_BROWSER_ENGINE=cef), the native engines stay as they were
- The handler only reads files, the native engines keep the UI thread
- The context menu loses its navigation entries, like the WebKitGTK and WKWebView filters - The drag handler keeps the paths of files dragged into the window for NativeFileDrop::claim - Once the app is loaded the window does not navigate: a reload loses the RPC setup, a dropped file replaces the app - WebKitGTK, GTK and WKWebView sources only build for the native engine, GLib is linked explicitly - Without --enable-dev-tools the DevTools port of Nui is removed from the environment
- Chromium hides their paths like WKWebView, the frontend is built with BROWSER_ENGINE=cef - The claim carries the file names, the backend only hands out paths of a drag with the same names
- -DNUI_BROWSER_ENGINE=native still builds with WebKitGTK or WKWebView, Windows stays on WebView2
- CEF needs the bundle in the build tree as well, the frontend is copied into its resources
- deploy.sh runs cmake --install on Linux and on macOS with CEF, Windows and WKWebView bundles keep their copies - The CEF runtime goes to lib/nui-sftp next to bin/, libcef is stripped while installing
- Engine option, how CEF is fetched or provided offline, DevTools over CDP, the installed layout - Drops from the desktop carry several files now, the WebKitGTK caveat is gone
- interval-tree is v3.1.1, the version Nui fetches
5cript
enabled auto-merge (rebase)
October 19, 2026 01:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Massively improves performance on linux and fixes the drop issue, that only 1 item could be dragged and dropped from a file manager program.
Resolves #237