Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject negative token counts in
calculate_cost_by_tokensinstead of silently returning a negative USD cost. Token counts represent usage quantities and cannot be negative; accepting them can invert a spend estimate and corrupt accounting.Changes
ValueErrorwith a clear message whennum_tokens < 0.Validation
e7f7c1928084af55bb4955102327982401ed8649because the function returns a negative cost instead of raising.PYTHONPATH=. .venv/bin/pytest -q tests/test_costs.py -k 'not claude': 94 passed, 2 deselected. The excluded pre-existing Claude cases invoke Anthropic's remote token-count API and require credentials.python -m compileallandgit diff --checkpass.flake8 tokencost/ tests/test_costs.pyreports 8 existing findings, all reproduced against unchanged base files; the patch adds no lint finding. A full lint pass is not claimed.