Repository navigation
TPC track reader: do not accumulate MC labels over entries - #15910
Merged
sawenzel merged 1 commit intoOct 8, 2026
Merged
Conversation
With one entry per call, TrackReader::accumulate swapped the tracks and cluster references of the new entry in, but appended its MC labels to mMCTruthOut, which is never cleared. From the second tree entry on, the consumers therefore got the labels of the first entry for the tracks of the current one (label i = label of track i of entry 0). Swap the labels as well. Only visible when a tpctracks.root holds more than one TF (e.g. merged MC files); O2DPG writes one TF per file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
October 7, 2026 20:33
shahor02
approved these changes
Oct 8, 2026
shahor02
left a comment
shahor02
left a comment
Collaborator
There was a problem hiding this comment.
note that the merge MC trees will not be supported by the MCKinematicsReader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With one entry per call, TrackReader::accumulate swapped the tracks and cluster references of the new entry in, but appended its MC labels to mMCTruthOut, which is never cleared. From the second tree entry on, the consumers therefore got the labels of the first entry for the tracks of the current one (label i = label of track i of entry 0). Swap the labels as well.
Only visible when a tpctracks.root holds more than one TF (e.g. merged MC files); O2DPG writes one TF per file.