Conversation
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
VDiBella
force-pushed
the
dev4
branch
7 times, most recently
from
September 30, 2026 15:21
8a34ace to
ec30e76
Compare
github-actions
Bot
added
pwglf
pwgcf
pwgud
infrastructure
and removed
pwglf
pwgcf
pwgud
infrastructure
labels
VDiBella
force-pushed
the
dev4
branch
5 times, most recently
from
October 2, 2026 16:57
34fe649 to
b9c876a
Compare
VDiBella
marked this pull request as ready for review
October 2, 2026 17:05
VDiBella
requested review from
NicoleBastid,
apalasciano,
gluparel,
hahassan7,
jpxrk,
singhra1994,
stefanopolitano,
xinyepeng and
zhangbiao-phy
as code owners
October 2, 2026 17:05
VDiBella
marked this pull request as draft
October 2, 2026 17:15
VDiBella
marked this pull request as ready for review
October 2, 2026 17:43
Collaborator
VDiBella
marked this pull request as draft
October 2, 2026 23:22
VDiBella
marked this pull request as ready for review
October 2, 2026 23:34
Collaborator
VDiBella
marked this pull request as draft
October 2, 2026 23:42
VDiBella
marked this pull request as ready for review
October 2, 2026 23:42
vkucera
requested changes
Oct 3, 2026
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
- Please fix the O2 linter warnings.
- Please follow naming conventions.
- Why are you renaming table columns?
- Why are you adding index columns?
VDiBella
marked this pull request as draft
October 4, 2026 20:03
Contributor
Author
Thanks for the comment. |
VDiBella
marked this pull request as ready for review
October 4, 2026 20:11
Collaborator
|
Please do not force-push changes during the review. Now I cannot see what you have changed since my review. |
Collaborator
|
You still have warnings from O2 linter. |
Collaborator
|
You still don't follow the naming conventions at many places. |
vkucera
marked this pull request as draft
October 5, 2026 09:55
vkucera
reviewed
Oct 5, 2026
Comment on lines
+93
to
+98
| Configurable<std::vector<double>> minM{"minM", {0.7, 0.7}, "Mass minimal for the cut for each pt bin"}; | ||
| Configurable<std::vector<double>> maxM{"maxM", {2.0, 2.1}, "Mass maximal for the cut for each pt bin"}; | ||
| Configurable<std::vector<double>> minCosTheta{"minCosTheta", {0.96, 0.98}, "CosTheta minimal for the cut for each pt bin"}; | ||
| Configurable<std::vector<double>> minDecayLength{"minDecayLength", {0.02, 0.03}, "DecayLength minimal for the cut for each pt bin"}; | ||
| Configurable<std::vector<double>> maxNsigmaTPC{"maxNsigmaTPC", {3, 3}, "NsigmaTPC maximal for the cut for each pt bin"}; | ||
| Configurable<std::vector<double>> maxNsigmaTOF{"maxNsigmaTOF", {3, 3}, "NsigmaTOF maximal for the cut for each pt bin"}; |
Collaborator
There was a problem hiding this comment.
Please follow the HF naming conventions.
The quantity comes first, the attributes after, just like when you write the symbols in equations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the possibility of doing Machine Learning and skimming in the correlator, mainly for MonteCarlo data.
Other minor change include mostly some cleaning of names and adding 2d histograms.