Repository navigation
Conversation
Add a storeEProt toggle to the 3D qn THnSparse in FemtoDreamContainer and femtoDreamPairTaskTrackTrack. When enabled, the out/side/long momentum-difference axes are replaced by DK_x, DK_y, DK_z rotated into the event-plane (magnetic-field) frame, so DK_y is out-of-plane (||B) for every pair. A single-component cut (e.g. on DK_x, DK_z) is applied offline on the output; this toggle only changes what is histogrammed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ootaku303
requested review from
alibuild,
ariedel-cern,
dimihayl,
dsarkaralice,
lauraser,
victor-gonzalez and
wrzesaCERN
as code owners
October 1, 2026 11:11
|
O2 linter results: ❌ 0 errors, |
wenyaCern
reviewed
Oct 5, 2026
lauraser
approved these changes
Oct 7, 2026
lauraser
enabled auto-merge (squash)
October 7, 2026 14:44
Collaborator
vkucera
reviewed
Oct 7, 2026
Comment on lines
+377
to
+385
| /// Signed φ_pair − Ψ_EP (same as getPairPhiEP without the final |·|); used as the B-frame rotation angle. | ||
| template <typename T1, typename T2> | ||
| static float getPairPhiEPSigned(const T1& part1, const float mass1, const T2& part2, const float mass2, const float Psi_ep) | ||
| { | ||
| const ROOT::Math::PtEtaPhiMVector vecpart1(part1.pt(), part1.eta(), part1.phi(), mass1); | ||
| const ROOT::Math::PtEtaPhiMVector vecpart2(part2.pt(), part2.eta(), part2.phi(), mass2); | ||
| const ROOT::Math::PtEtaPhiMVector trackSum = vecpart1 + vecpart2; | ||
| return TVector2::Phi_mpi_pi(trackSum.Phi() - Psi_ep); | ||
| } |
Collaborator
There was a problem hiding this comment.
Please consider replacing this with:
RecoDecay::constrainAngle(RecoDecay::phi(RecoDecay::pVec(part1.pVector(), part2.pVector())), -o2::constants::math::PI)For sure you don't need masses to calculate phi.
Comment on lines
+388
to
+398
| template <typename T1, typename T2> | ||
| static float getPairPhiEPSigned(const T1& part1, const float mass1, const T2& part2, const float mass2, const float Psi_ep1, const float Psi_ep2) | ||
| { | ||
| const ROOT::Math::PtEtaPhiMVector vecpart1(part1.pt(), part1.eta(), part1.phi(), mass1); | ||
| const ROOT::Math::PtEtaPhiMVector vecpart2(part2.pt(), part2.eta(), part2.phi(), mass2); | ||
| const float psidiff = Psi_ep2 - Psi_ep1; | ||
| const float newPhi2 = TVector2::Phi_mpi_pi(vecpart2.Phi() - psidiff); | ||
| const ROOT::Math::PtEtaPhiMVector vecpart2_calibd(vecpart2.Pt(), vecpart2.Eta(), newPhi2, vecpart2.M()); | ||
| const ROOT::Math::PtEtaPhiMVector trackSum = vecpart1 + vecpart2_calibd; | ||
| return TVector2::Phi_mpi_pi(trackSum.Phi() - Psi_ep1); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional storeEProt toggle to the 3D qn THnSparse in femto-dream-pair-task-track-track. When enabled, the out/side/long momentum-difference axes are replaced by DK_x, DK_y, DK_z rotated into the event-plane (B-field) frame, so DK_y is out-of-plane (||B) for every pair — useful for offline single-component cuts when searching for B-direction-dependent HBT modulation.
Default is false: booking and output are unchanged. Tested: builds clean against latest master, and a full 1-file run with storeEProt=true produces the expected relPair3dEProtRmTMultPercentileQnPairphi histogram (SameEvent 1.4×10⁸ / MixedEvent 2.5×10⁷ entries) with no change when the toggle is off.