Skip to content

[Tutorial,PWGCF,PWGHF,PWGLF] Remove default value for ignoring overflow when binning - #18163

Merged
ktf merged 1 commit into
AliceO2Group:masterfrom
ktf:pr18163
Oct 3, 2026
Merged

ktf merged 1 commit into
AliceO2Group:masterfrom
ktf:pr18163

Conversation

@ktf

@ktf ktf commented Oct 3, 2026

Copy link
Copy Markdown
Member

Needed to validate the fact that the overflow is not used by anyone.

Needed to validate the fact that the overflow is not used by anyone.
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1819 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Remove default value for ignoring overflow when binning [Tutorial,PWGCF,PWGHF,PWGLF] Remove default value for ignoring overflow when binning Oct 3, 2026
@alibuild

alibuild commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b3ad75f at 2026-10-03 16:36:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 683 warnings.'
Found 4 errors and 683 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/56f3eb00c286c2a7933b3a406b257a6c522063ef/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:633:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:666:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:1950:40: error: std::move of the expression of the trivially-copyable type 'value_type' (aka 'GenCoalescenceCandidate') has no effect [performance-move-const-arg,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:1955:38: error: std::move of the variable 'deuteron' of the trivially-copyable type 'GenCoalescenceCandidate' has no effect [performance-move-const-arg,-warnings-as-errors]
++ [[ 683 -gt 0 ]]
++ cat /sw/BUILD/56f3eb00c286c2a7933b3a406b257a6c522063ef/O2Physics-code-check/warnings.txt
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskTrackTrack.cxx:59:8: warning: constructor does not initialize these fields: random [cppcoreguidelines-pro-type-member-init]
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskTrackTrack.cxx:380:11: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskTrackTrack.cxx:785:27: warning: 5th argument 'myEP' (passed to 'myQnBin') looks like it might be swapped with the 6th, 'myqnBin' (passed to 'eventPlane') [readability-suspicious-call-argument]
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskTrackTrack.cxx:861:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskTrackTrack.cxx:863:17: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskTrackTrack.cxx:870:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskTrackV0.cxx:310:11: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGCF/FemtoDream/Tasks/femtoDreamPairTaskV0V0.cxx:53:8: warning: constructor does not initialize these fields: random [cppcoreguidelines-pro-type-member-init]
PWGCF/FemtoDream/Tasks/femtoDreamTripletTaskTrackTrackCascade.cxx:231:11: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGCF/FemtoDream/Tasks/femtoDreamTripletTaskTrackTrackTrackPbPb.cxx:214:11: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGCF/FemtoDream/Tasks/femtoDreamTripletTaskTrackTrackTrack.cxx:206:11: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGCF/FemtoDream/Tasks/femtoDreamTripletTaskTrackTrackV0PbPb.cxx:298:11: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGCF/FemtoDream/Tasks/femtoDreamTripletTaskTrackTrackV0.cxx:282:11: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:393:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:395:132: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:397:128: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:403:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:457:298: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:460:298: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:466:97: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:316: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:488:316: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:491:97: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:517:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:521:377: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:532:298: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:535:298: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:541:97: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:565:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:574:298: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:577:298: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:594:283: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:598:246: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:601:285: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:619:184: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:645:91: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@ktf

ktf commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

Mechanical substitution of default value. Merging.

@ktf
ktf merged commit ca1c3d8 into AliceO2Group:master Oct 3, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants