Skip to content

[PWGCF] Addition of DihadronContainer to CorrReso. Minor code structuring in … - #18259

Merged
wenyaCern merged 4 commits into
AliceO2Group:masterfrom
Preet-Bhanjan:master
Oct 16, 2026
Merged

wenyaCern merged 4 commits into
AliceO2Group:masterfrom
Preet-Bhanjan:master

Conversation

@Preet-Bhanjan

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Oct 12, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild

alibuild commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 20b6f6c at 2026-10-16 01:59:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 9 warnings.'
Found 5 errors and 9 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/b5628956f70f1c1ff51f51202b3a3eaac7b9b76e/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:21:1: error: included header TriggerAliases.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:54:1: error: included header TString.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:56:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:1143:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:1258:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/b5628956f70f1c1ff51f51202b3a3eaac7b9b76e/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:72:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:89:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:498:9: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:684:11: warning: variable 'cent' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:771:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:811:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:1045:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:1047:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx:1940:33: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@Preet-Bhanjan
Preet-Bhanjan marked this pull request as draft October 16, 2026 03:43
@Preet-Bhanjan
Preet-Bhanjan marked this pull request as ready for review October 16, 2026 04:48
@wenyaCern
wenyaCern merged commit 26e73dd into AliceO2Group:master Oct 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants