Skip to content

[PWGUD] Add task upcTrackVertexingQA.cxx - #18278

Merged
amatyja merged 25 commits into
AliceO2Group:masterfrom
ariffero:upc-task-force
Oct 13, 2026
Merged

amatyja merged 25 commits into
AliceO2Group:masterfrom
ariffero:upc-task-force

Conversation

@ariffero

Copy link
Copy Markdown
Contributor

Add task to study properties of TPC tracks. Used for the study of the vertexing efficiency in UPC. Done with @atavirag

atavirag and others added 23 commits September 21, 2026 15:45
Modify QA task for TPC tracks
Improve histos in upcTrackVertexingQA.cxx
*This code needs to be cleaned*
- Physics-inspired cuts removed
- Track association done before creating the candidate or asking for exactly two tracks
- New process function: processTracksIU
- New control plots
- use addClone to create similar hostos
- use the same function to fill Trk and Trk/Coll histos
- delete the cut flow and the cut flow histograms
- change function for gen MC, now process functions are different for embedded and exclusive MC
- fix o2linter warnings
@github-actions github-actions Bot added the pwgud label Oct 13, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#18278
@ariffero
ariffero marked this pull request as ready for review October 13, 2026 15:42
@ariffero
ariffero requested a review from alibuild as a code owner October 13, 2026 15:42
@amatyja
amatyja enabled auto-merge (squash) October 13, 2026 15:55
@amatyja
amatyja merged commit 3e98361 into AliceO2Group:master Oct 13, 2026
14 of 15 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 44ca90e at 2026-10-13 22:23:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 9 errors and 3 warnings.'
Found 9 errors and 3 warnings.
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/62545d68a10220b2c8384e01b264230c5cbaa7ca/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcTrackVertexingQA.cxx:17:1: error: included header EventSelectionParams.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:33:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:34:1: error: included header TH1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:35:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:36:1: error: included header TPDGCode.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:75:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:198:44: error: no header providing "o2::constants::lhc::LHCMaxBunches" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:341:17: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcTrackVertexingQA.cxx:416:10: error: the variable 'motherPart' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/62545d68a10220b2c8384e01b264230c5cbaa7ca/O2Physics-code-check/warnings.txt
PWGUD/Tasks/upcTrackVertexingQA.cxx:53:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGUD/Tasks/upcTrackVertexingQA.cxx:88:22: warning: member 'twoTracks' of type 'const unsigned int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGUD/Tasks/upcTrackVertexingQA.cxx:89:13: warning: member 'unassignedDCA' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
++ [[ 9 -gt 0 ]]
++ exit 1
--

Full log here.

@ariffero
ariffero deleted the upc-task-force branch October 14, 2026 12:51
@vkucera

vkucera commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Dear @ariffero @atavirag . Please fix the reported errors.

@atavirag

Copy link
Copy Markdown
Contributor

Dear @ariffero @atavirag . Please fix the reported errors.

Hi @vkucera, the errors are addressed in this PR: #18286, but it hasn't been merged yet.

@vkucera

vkucera commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Dear @ariffero @atavirag . Please fix the reported errors.

Hi @vkucera, the errors are addressed in this PR: #18286, but it hasn't been merged yet.

Ah, very good! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants