Repository navigation
fix/#116-feedback-interview-status - #115
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
danjee2009
changed the title
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116
Closes #116
Task
FeedbackSoloRequest·FeedbackMultiRequest에interviewStatus필드를 추가하고 채점 직전에 검사한 DB의 면접 상태를 싣도록 수정했습니다.FeedbackService의requestFeedback,requestFeedbackForFinishedInterview,startFeedback에서Status.COMPLETED인 면접만 채점을 허용하도록 실행 자격을 통일했습니다.requestFeedback)에서ABANDONED·IN_PROGRESS면접은 기존PENDING/SUCCEEDED/FAILED재시도 판정 전에 HTTP 409로 거절하고, 자동 요청(requestFeedbackForFinishedInterview)에서는 외부 호출 없이 종료하도록 변경했습니다.interviewStatusJSON 직렬화 단위 테스트(T1~T8)를 추가·갱신했습니다.ETC
Doc/demo-fix-spec/2026-10-20-시연-전-긴급수정-명세.md§3 및docs/abandoned-interview-feedback/02-api-server.md(docs: 면접 중도 종료 시 피드백 생성 방지 구현 명세 #111 / docs/#111-abandoned-interview-feedback #112) §1~§4 실행 부분./gradlew test전체 통과 확인