Repository navigation
codex/general-job-chat - #51
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
danjee2009
left a comment
danjee2009
left a comment
There was a problem hiding this comment.
검토 범위: 일반 직군 면접관 선택, 프롬프트 조립, 후속 질문 요청 DTO와 관련 테스트. 전체 PR diff를 정적으로 확인했으며 외부 LLM 호출 검증은 수행하지 않았습니다. 확인된 추가 지적 사항은 없습니다.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b68c8e7bbf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case GEN_STRATEGY, GEN_HR_ADMIN, GEN_FINANCE, GEN_MARKETING, GEN_SALES, GEN_DESIGN -> | ||
| isGeneralInterview(request) ? generalMajorInstruction(request) : ""; |
There was a problem hiding this comment.
In a general MULTI interview, non-TECH personas may validly have persona.major == null; the service forwards that as request.major while placing the session category in request.interviewMajor. This switch therefore takes case null and never invokes generalMajorInstruction, so those interviewers' prompts omit both the general-job perspective and the supplied jobTitle. Use interviewMajor when the session is general rather than requiring each persona to repeat the session major.
Useful? React with 👍 / 👎.
| if (request.getRole() == null || request.getRole() == InterviewRole.TECH) { | ||
| String instruction = "직무 판단의 근거와 실행 과정을 확인하세요."; | ||
| if (request.getInterviewMajor() == InterviewMajor.GEN_DESIGN) { | ||
| instruction += "\n결과물의 시각적 완성도는 묻지 마세요."; |
There was a problem hiding this comment.
For a GEN_DESIGN interview whose current persona has role HR, CEO, PM, or DESIGN, execution skips this branch and returns directly from the role switch below. The prompt consequently loses the requirement not to assess visual completeness, allowing non-TECH panelists to generate exactly the questions this design-specific rule is intended to prohibit. Append this instruction independently of the persona role.
Useful? React with 👍 / 👎.
일반 직군 명세 G-C7
Task
jobTitle을 면접 준비·세션·꼬리질문에 전달합니다.검증
./gradlew test: 295개 중 291 성공, 실패 0. 로컬redis-server실행 파일 부재로 기존 Redis 통합 4개 생략(CI는 설치 후 생략 여부 검사).git diff --check완료. 상세:docs/general-job-implementation.md.ETC