Repository navigation
fix: 생성된 면접 확인 시 N:1 면접관 순서 차이를 불일치로 보지 않음 - #173
Conversation
API가 N:1 면접관을 기술 면접관 먼저로 재정렬해 저장하므로 getCreatedInterview는 구성만 비교하고 순서는 비교하지 않는다. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c2990020b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ("personaIds" in params && (params.personaIds.length !== data.personaIds.length || | ||
| params.personaIds.some((id, index) => data.personaIds[index] !== id))) { | ||
| params.personaIds.some((id) => !data.personaIds.includes(id)))) { |
There was a problem hiding this comment.
When the server returns the same persona IDs in a different order—the exact N:1 scenario this change now accepts—the returned data.personaIds remains in server order. buildPreparedView later pairs those IDs by index with the original settings.slots (prepareView.ts:22-25), so questions from one persona highlight and display another interviewer's name, role, image, and traits. After validating set equality, restore the request order or explicitly map each ID to its originating slot before returning the data.
Useful? React with 👍 / 👎.
개요
release PR #172 리뷰에서 나온 지적 사항 수정입니다.
기준 커밋:
origin/dev954692b문제
getCreatedInterview가 요청 때 보낸personaIds와/api/interviews/get응답의personaIds를 순서까지 비교했습니다.API(
InterviewService.orderForMulti)는 N:1 면접관을 기술 면접관 먼저로 재정렬해personaOrder로 저장합니다. 그래서 기술 면접관을 첫 자리에 두지 않은 설정은 이미 만들어진 면접인데도 "생성된 면접관 정보가 선택한 설정과 일치하지 않습니다"가 떴습니다. 사용자가 재시도하면 면접이 중복으로 생길 수 있었습니다.변경
src/features/interview-page/interview/api/create-interview/index.ts: 길이와 포함 여부만 비교하고 순서는 비교하지 않음. API가 중복 ID를 거절하므로 길이와 포함 여부만 맞으면 같은 구성으로 봄테스트
npm run lint오류 0(기존router.tsx경고 1),npm run build통과node --test tests/*.test.mjs) 51개 통과tests/profile-preparation.browser.mjs28개 통과start 404 links to materials (server reorders personas):/api/interviews/get이 면접관을 역순으로 돌려줘도 다음 단계로 진행🤖 Generated with Claude Code