Repository navigation
fix: 질문 음성 PENDING 응답 후 재요청에 최소 1초 간격 적용 - #174
Merged
Merged
Conversation
서버가 long-poll 대기 없이 PENDING을 바로 돌려주면 대기 없이 재요청이 반복되던 문제를 막는다. 기존 오류 재시도 대기 로직을 공용 wait로 정리했다. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
release PR #172 리뷰에서 나온 지적 사항 수정입니다.
기준 커밋:
origin/dev954692b문제
useQuestionAudio는status: PENDING을 받으면 대기 없이 바로 다시 요청했습니다. 서버의wait=20long-poll(Chatdefault-wait 20s / max-wait 25s)만 믿는 구조라, Chat 설정이 바뀌거나 프록시가 PENDING을 바로 돌려주면 180초 동안 요청이 쉬지 않고 Chat으로 몰릴 수 있었습니다.변경
src/features/interview-page/interview/model/useQuestionAudio.tsPENDING_MIN_INTERVAL_MS = 1_000[가정]: 요청을 보낸 뒤 1초 안에 PENDING이 오면 남은 시간만큼 기다렸다가 다시 요청. long-poll이 정상이면(20초 대기) 추가 지연 없음wait로 묶어 PENDING 대기에도 같이 씀. 질문 전환·종료 시 정리(releaseRetry,retryTimer)도 그대로 적용됨tests/interview-browser-fixture.mjs: 오디오 요청에 시각(at) 기록tests/question-audio.browser.mjs: PENDING 연속 시나리오에서 요청 간격이 900ms 이상인지 검사테스트
npm run lint오류 0(기존router.tsx경고 1),npm run build통과node --test tests/*.test.mjs) 51개 통과tests/question-audio.browser.mjs23개 통과(백오프 초기화·180초 마감·질문 전환 정리 회귀 포함)🤖 Generated with Claude Code