Repository navigation
Antalya 26.3 Backport of #102156 - Fix Nullable(X)->Y cross-type ALTER MODIFY COLUMN - #2712
Conversation
…pe-modify-upstream Fix Nullable(X)->Y cross-type ALTER MODIFY COLUMN
CI triage for
|
| Check | Failing tests | Verdict |
|---|---|---|
| Stateless tests (amd_debug, sequential) | 03271_s3_table_function_asterisk_glob, 02789_filesystem_cache_alignment (+2 that passed on retry) |
Already failing on the base branch |
| Stateless tests (amd_debug, distributed plan, s3 storage, sequential) | 03271_s3_table_function_asterisk_glob, 02789_filesystem_cache_alignment |
Already failing on the base branch |
| DCO | n/a | Metadata only: the commit has no Signed-off-by |
The PR changes only src/Interpreters/inplaceBlockConversions.cpp and adds the test 03575_modify_column_null_to_default_cross_type. All parallel suites (asan/debug/ubsan, 0 failures) passed, and so did the ubsan and asan-db-disk sequential suites. None of the failing tests touch ALTER MODIFY COLUMN or Nullable conversion.
1. 03271_s3_table_function_asterisk_glob (both debug sequential suites, failed again on retry)
Error on processing query: Timeout exceeded while receiving data from server. Waited for 300 seconds, timeout is 300 seconds.
(query: SELECT * FROM s3('https://clickhouse-public-datasets.s3.amazonaws.com/wikistat/original/*', NOSIGN) LIMIT 1 FORMAT Null;)
- The query that hangs lists a large external public S3 bucket (
wikistat/original/*), so the timeout comes from the runner's network or the debug build's speed, not from ALTER code. - Evidence it's already broken: Antalya 26.3: Bump to 26.3.60 #2707 (the version bump to 26.3.60, no code changes) fails the same test in the same two suites (report).
2. 02789_filesystem_cache_alignment (both debug sequential suites, failed again on retry)
02789_filesystem_cache_alignment: [ FAIL ] 600.04 sec.
Reason: Timeout! Processes left in process group ... (stuck in the SELECT over system.remote_data_paths / filesystem cache segments)
- This is a filesystem-cache test, and it hit the 600 s test timeout.
- Evidence it's already broken: Antalya 26.3: Bump to 26.3.60 #2707 fails it the same way in both suites.
- The CI "known broken" rule for timeouts ("Random timeout with sanitizer") only covers tsan/asan/msan/ubsan builds. That's why these timeouts aren't hidden on
amd_debug(seebroken_tests_handler.log).
3. Tests that failed once and passed on retry (amd_debug, sequential)
04306_delta_lake_merge_missing_table_state: got\Ninstead of1/2on the first run (a failpoint test for DeltaLake). Passed on retry. Unrelated to this PR.02346_text_index_hits:TOO_SLOW(estimated 1577 s, maximum 600) while insertingtest.hits, which is the debug build being slow. Passed on retry.
4. DCO
The only commit, ede57c1a ("Merge pull request ClickHouse#102156 from il9ue/…", the upstream merge commit cherry-picked as-is), has no Signed-off-by: line. Other 26.3 backports have the same problem (e.g. #2697 is also red on DCO).
Fix options:
- A maintainer marks DCO as passed from the check's details page. This is the usual approach for upstream backports.
- Or someone re-signs the commit (
git commit --amend -s) and force-pushes. I can't do that because force-push is outside my permissions.
Adding a new signed commit on top won't help, because DCO checks every commit in the PR.
Suggested next steps
- No code changes needed in this PR.
- If you want the sequential suites green, re-run them.
03271/02789will probably fail again until they're fixed on theantalya-26.3base branch, since they currently fail on unrelated PRs too. A follow-up could add them totests/broken_tests.yamlforamd_debug, or make03271stop depending on listing the publicwikistatbucket. - Fix DCO as above.
Evidence: result_pr.json, job.log and broken_tests_handler.log for this PR's head, compared with the reports for #2707, #2714, #2697 and #2684. I did not run anything locally.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed
ALTER MODIFY COLUMNfailing when converting aNullablecolumn to a different type with aDEFAULT(e.g.Nullable(UInt8)→String,LowCardinality(String), orArray(UInt8)). (ClickHouse#102156 by @il9ue)Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: