Repository navigation
Conversation
Apply the mount floor to candidates without a catalog row. Recheck each candidate's full catalog row after floor reads and before reading bodies. Retain candidates whose namespace appears, disappears, or changes life. Add deterministic regressions for staged publication and catalog races. Verification: 8/9 regressions failed before the fix; 9/9 pass after it. https://gist.github.com/filimonov/1b96ea358804b1c6e22c45380cc65469 https://gist.github.com/k-morozov/13a60ab4424b1b20ba54e4d89b1c0917 Signed-off-by: Konstantin Morozov <just.morozov.k@gmail.com>
Cover rowless mount floors, epoch boundaries, per-namespace catalog changes, cursor progress after retention, and catalog request counts. Document the floor and catalog checks before candidate body reads. Verification: unit_tests_dbms built successfully; 53 tests from CASOrphanManifestSweep, CASOrphanSweepRequests and CASSweepDeletionPremise pass. Scoped whitespace checks and documentation anchors pass. https://gist.github.com/filimonov/1b96ea358804b1c6e22c45380cc65469 https://gist.github.com/k-morozov/13a60ab4424b1b20ba54e4d89b1c0917 https://gist.github.com/k-morozov/5c81c35c5ea432c36f4467ece81dc2ce Signed-off-by: Konstantin Morozov <just.morozov.k@gmail.com>
Move mount-floor eligibility into `isBuildBelowFloor` and the second catalog cut into `filterCandidatesByCatalog`. Keep cursor progress in `planManifestCursorPage` and preserve skip accounting. Preserve floor caching, request counts and the order of observations. https://gist.github.com/filimonov/1b96ea358804b1c6e22c45380cc65469 https://gist.github.com/k-morozov/13a60ab4424b1b20ba54e4d89b1c0917 Signed-off-by: Konstantin Morozov <just.morozov.k@gmail.com>
Use `excludeCandidatesWithChangedCatalogEntries` and `rechecked_catalog` to describe the catalog recheck and its candidate filtering. https://gist.github.com/filimonov/1b96ea358804b1c6e22c45380cc65469 https://gist.github.com/k-morozov/13a60ab4424b1b20ba54e4d89b1c0917 Signed-off-by: Konstantin Morozov <just.morozov.k@gmail.com>
This was referenced Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix races in CAS garbage collection that could delete manifests during namespace creation or recreation, causing data loss.
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: