Repository navigation
Disable public JWE issuance and require an admin token - #188
Merged
Merged
Conversation
…180-admin-token-generator # Conflicts: # CHANGELOG.md
…en-generator # Conflicts: # CHANGELOG.md # cmd/altinity-mcp/credential_transport.go
BorisTyshkevich
marked this pull request as ready for review
October 7, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JWE token generator is now disabled by default. Operators must explicitly enable it and configure an admin bearer secret of at least 32 bytes; startup and reload reject insecure enabled configurations, and disabled deployments return 404.
Enabled issuance uses constant-time admin authentication, a 64 KiB limit on the complete JSON body, a configurable maximum lifetime, and the same TLS file allowlist as JWE clients. Issuance logs host, username, and expiry without passwords, tokens, or secrets. Documentation and Helm values include the migration and administrative network guidance.
Closes #180.
Validation at 02ea048: go vet, full Go tests, the CI-matched shuffled coverage command, make build, full server race tests, and full command-package race tests passed. Independent repeated logging and symlinked-TMPDIR TLS round-trip/rotation race checks passed. CI passed. Independent native Sol/xhigh and external Opus/xhigh reviews returned SHIP after all material findings were fixed. No required check was waived. The optional separate listener is deferred; the generator shares the HTTP/SSE listener.