Repository navigation
Escape the azblob CopyObject source URL, fix #1637 - #1638
Merged
Slach merged 4 commits intoOct 28, 2026
Merged
Conversation
The rebase scenario used plain `test_rebase_<storage>` / `t1` names, which common.TablePathEncode keeps as is, so no remote key passed to CopyObject ever contained a literal `%` and the azblob copy source escaping bug (Altinity#1637) went unnoticed. Names now contain `-`, `.`, `#`, `$`, Cyrillic and a leading dot like `.inner_id.<uuid>`; without the fix TestRebaseAzblob fails with BlobNotFound, every TestRebase* backend passes with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
@shubhamkapoor01 thanks for your contribution |
…rce-escape # Conflicts: # ChangeLog.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix https://github.com/Altinity/clickhouse-backup/issue/1637
Azure decodes the copy source path, so encoded names like
test%2Ddbpointed at a blob that doesn't exist andrebasefailed withBlobNotFound. This escapes the source URL likes3CopySourcedoes for S3, as @kolsys suggested.Checked against Azurite: copying a part of
test-dbor of a.inner_id.table fails on master and works with this change.