Repository navigation
Fix --link-dest quoting in the rsync upload example - #1639
Merged
Merged
Conversation
The single quotes inside DIFF_FROM_REMOTE_CMD survive the unquoted expansion, so rsync reports "--link-dest arg does not exist" and copies every file instead of hard-linking unchanged parts. Signed-off-by: Ali Afsharzadeh <afsharzadeh8@gmail.com>
An unquoted string expansion still word-splits and globs the path, so
--link-dest broke on directories with spaces or glob characters. A bash
array keeps the path as one argument; the ${arr[@]+...} form keeps
set -u happy on bash < 4.4 when no --diff-from-remote is given.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
@guoard thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single quotes inside DIFF_FROM_REMOTE_CMD survive the unquoted expansion, so rsync reports "--link-dest arg does not exist" and copies every file instead of hard-linking unchanged parts.