Repository navigation
ci: run examples/ against the installed native wheel (#192) - #193
Merged
Merged
Conversation
New job "Examples on the installed wheel" in test-native.yml: the four platforms, Python 3.12 and 3.14 (a pull request: linux-x86_64, 3.12), the wheel the build job already uploads, installed with uv. The per-example arguments, timeouts, dataset handling and the answer check of example 10 move out of test-python-examples.yml into scripts/run_examples.sh, which both workflows call, so the JVM job behaves as before. scripts/native_examples_skip.txt lists, with a reason, the examples that need the JVM package (empty to start); the runner prints it. examples-summary is the one check for all legs. The native workflow also runs when examples/ or the runner change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…6.11.1 one (#192) From the first runs of the job (all four platforms, Python 3.12 and 3.14, the same nine failures everywhere): 02, 03 and 25 use jpype directly, 14 starts the JVM itself, 15 reads Java Schema objects (NotOnNativeYet), 29 needs the vectorNeighbors where option of engine 26.11.1 while the CI native image links 26.10.2. Examples 04, 05 and 06 are not listed: they failed on a bug (#195), fixed by PR #196, which this branch is rebased on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192
uv add arcadedbinstalls the native package, butexamples/only ran againstarcadedb-jvm. This adds a job totest-native.ymlthat runs every example on the installed native wheel.Examples on the installed wheel (<key>, Python <py>): the four platform keys, Python 3.12 and 3.14 (a pull request:linux-x86_64, 3.12). It downloadsnative-wheel-<key>from the build job (no rebuild) and installs it withuv syncin a throwawayexamples-envproject, like the JVM examples job.jpype1is not installed, becauseuv add arcadedbdoes not install it.test-python-examples.ymlintoscripts/run_examples.sh(datasetsandrun). Both workflows call it. The JVM job now has two one-line steps and sets no skip file, so it behaves as before.scripts/native_examples_skip.txt, lines of<file>.py | <reason>. It starts empty. The runner prints the list with the reasons and counts each listed example as skipped. I will add an example only after CI shows it fails on native because of a JVM-only API, not because of a bug.Examples summaryjob that is red when any leg fails.examples/**(exceptexamples/README.md),scripts/run_examples.shor the skip list change. The nightly "changed in the last 25 hours" check countsexamplestoo.select_native_matrix.pyhas a newexamplesoutput, with tests.release-native.ymlstill reads only thenative-passed-*markers and thenative-wheel-*wheels. A release run does run the examples on 3.12 and 3.14 only.Checked locally:
uvx pre-commit runon the changed files (black, isort, shfmt, actionlint),bash -non the runner, a dry run of the runner with and without a skip file, andtests/test_select_native_matrix.py. The first real run of the new job is this PR's CI; examples 02, 03 and 25 importjpypeand are the likely first candidates for the skip list.🤖 Generated with Claude Code