Repository navigation
Conversation
When file_get_contents() fails (for example with allow_url_fopen=0), the PHP warning was swallowed and the error claimed the URL returned invalid data. Throw with the first warning instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4.
When
file_get_contents()fails to download an IANA bootstrap file,AbstractRdapService::fromURL()swallowed the PHP warning and threw:That made #4 hard to diagnose; the real cause there was
allow_url_fopen=0. Now the first PHP warning is included:The exception class is still
InvalidServiceDefinitionException, so existingcatchblocks keep working. Content that downloads but is not a valid bootstrap file still produces the "return invalid data" message.With
allow_url_fopendisabled, the bootstrap files and RDAP queries can now go through a PSR-18 client instead (#6):phpcs and phpstan pass; checked with
php -d allow_url_fopen=0and with it enabled.