Repository navigation
Conversation
RdapClientInterface::IPV6 is now 'ipv6'. 'ipv46' is kept as an alias in hasProtocol() and getProtocol(), so code passing the old string keeps working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RdapClientInterface::IPV6had the value'ipv46', which looks like a typo next toIPV4 = 'ipv4'. It is now'ipv6'.The value is also what
guessType()returns and whatrequest()/getProtocol()accept, so callers might pass the string'ipv46'directly. To avoid breaking them,'ipv46'stays as an alias:Client::IPV6'ipv46''ipv6'guessType('2a00:1450:4001::1')['ipv46', ...]['ipv6', ...]getProtocol('ipv6')UnsupportedProtocolExceptionIPv6ProtocolgetProtocol('ipv46')/request($ip, 'ipv46')IPv6ProtocolIPv6Protocol(same instance as'ipv6')hasProtocol('ipv46')truetrueThe only visible change is the value of the constant and of
guessType()[0]. Code comparing either against the literal'ipv46'would need updating; code usingClient::IPV6is unaffected.phpcs and phpstan pass (also with
phpVersion: 80100). Checked live withipv6()andrequest($ip, 'ipv46').