Repository navigation
Conversation
The loop stored the protocol class name instead of the given instance and then fell through to the exception after break. Store the instance and return once a matching protocol type is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client::setProtocol()could never succeed:$obj) instead of the given instance, andbreakfell through to thethrow, so every call threwInvalidServiceDefinitionException: Service protocol "..." is not supported.Now the instance is stored and the method returns once a matching protocol type is found. An unsupported protocol still throws.
phpcs and phpstan pass.