Skip to content

Fix AbstractRdapService::remove() deleting the wrong array element #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomsommer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix AbstractRdapService::remove() deleting the wrong array element #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/Services/AbstractRdapService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use DateTimeImmutable;
use DateTimeInterface;
use DateTimeZone;
use function array_key_exists;
use function array_keys;
use function array_merge;
use function array_search;
Expand Down Expand Up @@ -279,15 +278,14 @@ public function remove(string $definition): void
if ($offset === false) {
continue;
}
if (array_key_exists($offset, $this->services[$key])) {
unset($this->services[$key][$offset]);
}
if (empty($this->services[$key])) {
unset($this->services[$key][0][$offset]);
if (empty($this->services[$key][0])) {
unset($this->services[$key]);
continue;
}
$this->services[$key] = array_values($this->services[$key]);
$this->services[$key][0] = array_values($this->services[$key][0]);
}
$this->services = array_values($this->services);
}

/**
Expand Down
Loading