Repository navigation
fix(api): stop doubling the extension on stem zip filenames - #1061
Merged
Merged
Conversation
Stems with no orig_filename often carry the upload's extension in the title
(" 🍕DRUMS.wav"), so the zip named them "DRUMS.wav.wav". Swap a trailing
audio extension in the title for the one from the blob's content type.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1060, found validating it in prod.
Stems indexed with no
orig_filenameoften have the upload's filename as their title (" 🍕DRUMS.wav"). The zip's fallback tookcreateFilename'stitle + ".mp3", stripped the.mp3, and added the extension from the blob's content type. Andrew Lux's "Alone" zip came out withDRUMS.wav.wav,LEADS.wav.wavand so on, 11 of 12 entries. Now a trailing audio extension in the title is replaced instead of kept. Tests cover the emoji/whitespace title, case, a different content type, and a title with a dot but no extension.Not changed here: the single-file
/tracks/{id}/downloadnames the same filesDRUMS.wav.mp3even though it serves the WAV, becausecreateFilenameassumes the transcode wheneverorig_filenameis empty.🤖 Generated with Claude Code