Repository navigation
Build assets with Node 24 in CI - #104
Merged
Merged
Conversation
Node 20 reached end of life in April 2026. Node 22 and 24 builds produce byte-identical assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103.
Builds the assets in CI with Node 24 instead of Node 20, which reached end of life in April 2026. BioSpex already uses Node 24.
Only
node-versionin.github/workflows/deploy-environment.ymlchanges. The servers don't run Node; it's only used to build the CSS and JS that the deploy uploads.Checked locally: building
developmentfrom a clean export (yarn install --frozen-lockfileandnpm run production) with Node 22 and Node 24 gives byte-identical output, with the same size and SHA-256 hash for every CSS and JS file.The pull request checks don't run the build, so the first development deploy after merging is the real test.