Repository navigation
Remove Slick - #99
Merged
Merged
Remove Slick#99
Conversation
Slick was loaded on every page but no view has a carousel. It also relies on $.type(), which jQuery 4 removes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98.
Removes Slick, which was loaded on every page but never used:
main.jsran$('.slick-slider').slick(), and no view has a.slick-sliderelement. Slick also calls$.type(), which jQuery 4 removes (#94), so it would have broken as soon as a carousel was added.resources/js/vendor/slick.min.js, its import inapp.js, andaxilSlickActivationinmain.js.slick.cssandslick-theme.css, their imports inapp.css, the Slick fonts andajax-loader.gif(onlyslick-theme.cssused it), and the "Slick" line inmain.css's contents comment.Checked locally on digitizationacademy.test:
npm run productionbuilds, the builtapp.jsandapp.csscontain no Slick, and the home, catalog (all three tabs load), course, calendar, team and contact pages load with no console errors.