Repository navigation
feat: give associated Markdown files a dedicated document icon - #652
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Markdown files associated with Leafdown use the approved folded-page icon with the green leaf above the Markdown symbol. Both Windows installers bundle it separately and register its quoted path, preserving the application icon and the user's default-app choice.
Related Issue
Closes #651
Verification
pnpm check:backendpasses, covering bundled icon registration, ICO frame dimensions, and existing file-association consent behavior.pnpm tauri build --bundles 'nsis,msi'builds both release installers. MSI extraction and the generated NSIS script confirm the installed filename, registered path, and uninstall ownership; the extracted MSI icon matches the approved asset.LoadImageandGetIconInfoload every supplied ICO size at its requested dimensions. The MSI's application icon matches the existing asset.pnpm check:frontendpasses formatting, lint, the production build, tests, and coverage.git diff --checkpasses.pnpm test:e2e:desktop:run -- --workers 1against the current head, including clean teardown.Not verified: installed Explorer rendering and icon-cache refresh, or install/upgrade/reinstall/repair/uninstall scenarios on a Windows test machine.