Repository navigation
fix: show heading caret markers only while the editor is focused - #654
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening a heading-first document no longer shows its caret marker before the editor receives focus. Focus and blur update the marker without moving the selection or changing Markdown; heading hover indicators and folding remain available.
Related Issue
Closes #647
Verification
pnpm exec vitest run src/features/editor/plugins/markerPresentation.test.ts src/features/editor/plugins/headingFold.test.ts src/features/editor/utils/headingOutline.test.ts— focus changes preserve selection, content, and undo history, and heading navigation and folding retain their behavior.pnpm check:frontendpassed its formatting, type-checking, lint, and production-build stages.pnpm exec vitest run --coverage --maxWorkers=2passed the full frontend suite and coverage floors.pnpm exec tsc -p e2e/desktop/tsconfig.json --noEmit,pnpm build:e2e:desktop, andpnpm test:e2e:desktop:run -- --scenario heading-outlinepassed on Windows, covering fresh opens, focus and blur, same-document reloads, outline navigation, hover markers, and folding.pnpm exec vitest run src/features/editor/tests/mathProjection.test.ts --maxWorkers=2passed. Layout and table-escape assertions use a deterministic fast-render clock, while the separate costly-preview test verifies deferred rendering.CI passed frontend checks, backend checks, the Rust dependency audit, and the full Windows desktop E2E suite for
e500222744100c26a521c498752a7ad33b46aeda.Not verified: desktop behavior on macOS or Linux.