Skip to content

Thread-Safety Issues #14

Description

@carlbennett

This issue was created to track thread-safety issues in the early stages of the development of Atlas.

Activity

  1. changed the title [-]Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a `lock{}` around it.[/-] [+]Thread-Safety Issues[/+] on Dec 1, 2020
  2. carlbennett commented on Dec 1, 2020

    @carlbennett
    MemberAuthor

    Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a lock{} around it.

    Originally posted by @carlbennett in #13 (comment)

  3. x3haloed commented on Nov 27, 2021

    @x3haloed

    Maybe I can help out. Are you worried about adding locks? If not, I can go through and analyze the multithreaded stuff so it's all thread-safe with locks.

  4. carlbennett commented on Dec 30, 2021

    @carlbennett
    MemberAuthor

    @x3haloed If you want to fork the project and assist by creating a pull request with your work, it would be reviewed and likely welcomed.

  5. linked a pull request that will close this issueNet10 upgrade and threading fixes #19on Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions