test: add credential-free tests for calls only covered by live tests by ffumero2003 · Pull Request #231 · Backblaze/blazer

ffumero2003 · 2026-10-29T19:46:13Z

Context

Part of the test-integrity audit (#97). Several calls were exercised only by live tests, which skip without B2 credentials, so go test ./... and CI never ran them:

hide and reveal;
download authorization, including b2ContentDisposition;
list and delete keys;
cancel large file;
the upload error mappings in base.Action.

x/transport, whose fault helpers blazer's own tests and downstream users rely on, had no test file at all. Credential-free statement coverage was 75.3%.

Changes

Test-only, plus the change's intent/credential-free-live-calls/ folder (intent, spec, plan). No production code changes.

b2/live_only_calls_wire_test.go (recording server, #205)

Req	Behavior pinned
R1	`Object.Hide` sends one `b2_hide_file` with `bucketId` and `fileName`, and a scripted error is returned
R2	`Bucket.Reveal` deletes the newest version when it is a `hide` marker, and sends no delete when it is an upload
R3	`Bucket.AuthToken` sends `fileNamePrefix` and `validDurationInSeconds` with no disposition, and returns the token
R4	`Object.AuthURL` sends `b2ContentDisposition` and returns a URL whose `Authorization` and `b2ContentDisposition` query values match
R5	`Client.ListKeys` sends `maxKeyCount`, maps name, ID and expiry, returns the cursor, sends it back as `startApplicationKeyId`, and returns `io.EOF` on an empty page
R6	`Key.Delete` sends `applicationKeyId`
R7	`Object.Cancel` sends `b2_cancel_large_file` for an unfinished file, and refuses an uploaded one without a request

base/live_only_calls_test.go (httptest)

Req	Behavior pinned
R8	A second upload on an upload URL that another upload is still using is refused by B2 (`400`, "more than one upload using auth token"). That maps to `AttemptNewUpload`, as does a connection reset before any response. A context the caller cancelled or let expire stays `Punt`.
R9	A cancelled context returns `context.Canceled`, and a deadline returns `context.DeadlineExceeded` with the server observing the cancellation
R10	An untrusted certificate fails with a certificate verification error, checked with `errors.As`

x/transport/transport_test.go (new). One test per helper: pass-through, FailureRate(0) and FailureRate(1), MatchPathSubstring, Response with Body, Stall (returns at its duration, or as soon as the request context ends), and AfterNBytes.

All coordination uses channels and context deadlines, with no fixed sleeps.

Split out or left out

fix(base): ListKeys drops key capabilities from b2_list_keys #220: ListKeys dropped key capabilities. The capabilities assertion failed on current code, so it was split into its own fix (fix(base): return key capabilities from ListKeys #228); R5 does not assert capabilities here.
Fix the x/transport data race and RoundTripper contract, the x/window divide-by-zero, and add tests #176: a transport.Trigger test reproduces that issue's data race under -race, so it is left out.

Verification

Each break was applied on its own, the test run, and the code restored. Every test passes once restored.

Req	Break	Failing output
R1	`HideFile` sends an empty file name	`fileName got "", want "gone"`
R2	`Reveal` inverts the `hide` check	`no request for b2_delete_file_version`
R3/R4	disposition dropped from the request, then from the URL	`b2ContentDisposition missing`; `got "", want "attachment…"`
R5	`ListKeys` drops the cursor	`startApplicationKeyId missing, want "k-3"`
R6	`Key.Delete` sends an empty ID	`applicationKeyId got "", want "k-1"`
R7	`Cancel` inverts the status check	`pending is not an unfinished large file: start`
R8	the shared-token case removed from `Action`	`Action(…more than one upload using auth token…) = 3, want AttemptNewUpload`
R8	the pre-response upload fault case removed	`Action(b2_upload_file: 0: EOF) = 2, want AttemptNewUpload`
R11	`Response` drops its body	`got "", want "retry later"`
R11	`Stall` ignores the request context	`returned after 1.0005s, want before 500ms when the request context ends`

Credential-free coverage: 75.3% → 78.5%.
go test -race -count=5 -shuffle=on ./b2 ./base ./x/transport passes with B2_APPLICATION_KEY_ID, B2_APPLICATION_KEY, B2_ACCOUNT_ID and B2_ACCOUNT_KEY unset.
make ci passes.
SDK panel review (deep, all five roles): FIX in round 1. The Stall test passed even when Stall ignored the context. That is fixed (the Stall row above) and re-verified. Its nit, that the spec claimed capabilities coverage, is corrected.

Notes for reviewers

Stacked on test: add a shared recording B2 server for wire tests #205. Merge test: add a shared recording B2 server for wire tests #205 first, then retarget this PR to main. internal/b2wiretest is identical to test: add a shared recording B2 server for wire tests #205's.
The live tests are unchanged and still run with credentials.

Closes #203

…e tests Several tests pass while blazer sends the wrong request to B2, because each wire test builds its own fake server and most accept any body. Capture the problem and the outcome for a shared test helper before writing a spec. Refs #191

Spec R1-R12 define the internal/b2wiretest helper: recording, scripted responses, upload URLs and assertions, with no new dependencies and no public API. The plan orders the work, names a test per requirement and the break each test must catch. Refs #191

…test checks (#203)

Add hermetic HTTP and transport coverage for calls previously exercised only by credentialed live tests. ListKeys capabilities mapping is tracked separately in #220. The transport Trigger test is omitted because its existing race is tracked in #176. Closes #203

Assert that Stall returns before its duration when the request context ends. Align R5 with the separate ListKeys capabilities work in #220.

Treat scripted status zero as 200, reject empty JSON assertion paths consistently, and mark the server closed before draining HTTP handlers so late requests cannot report through a completed test. Document the path and header guarantees, the migrated test coverage, and the simulator contract NOT RUN rationale requested in PR #205.

serve and copyRequests both decoded a request body into a JSON map. Share one decodeJSON helper so the two paths cannot drift; a body that is not a JSON object still decodes to nil. The same change was reviewed on #211.

…server' into test-issue-203-credential-free-live-calls

…tial-free-live-calls

…s on short bodies Script newest-first and older versions for Reveal, and ensure AfterNBytes does not trigger when a request body ends before its threshold. Part of #203

Copilot

🟡 Changes recommended

The AfterNBytes tests do not verify one-shot behavior across requests on the same transport or response-byte counting, allowing regressions in both behaviors to pass unnoticed.

2 open issues

What changed in this PR

2 Important, 0 Nit, 0 Pre-existing.

Adds credential-free coverage for previously live-only B2 calls and transport fault helpers, supporting #203 and the test-integrity audit in #97. Production code and live tests remain unchanged.

Changes:

Adds wire tests for hide/reveal, download authorization, key listing/deletion, and large-file cancellation.
Tests upload error classification, cancellation, deadlines, TLS rejection, and transport helpers.
Records requirements, scope, and verification plans.

Checked the supplied changes against the requirements and transport implementation; tests were not run during this review. A human code owner must review the base-layer wire and authorization coverage.

File	Description
`x/transport/transport_test.go`	Adds credential-free tests for transport fault helpers.
`intent/credential-free-live-calls/spec.md`	Defines behavior and coverage requirements.
`intent/credential-free-live-calls/plan.md`	Records implementation order and mutation checks.
`intent/credential-free-live-calls/intent.md`	Establishes the test-only scope and constraints.
`base/live_only_calls_test.go`	Covers upload faults, context errors, and untrusted certificates.
`b2/live_only_calls_wire_test.go`	Verifies public API requests and response mappings.

_{Review effort: Balanced}

+	if got := calls.Load(); got != 1 {
+		t.Errorf("effect calls = %d, want 1", got)
+	}


+func TestAfterNBytesDoesNotTriggerForShortBody(t *testing.T) {
+	srv := transportTestServer(t)
+	var calls atomic.Int32
+	client := &http.Client{Transport: WithFailures(nil, AfterNBytes(3, func() {
+		calls.Add(1)
+	}))}
+	resp := transportRequest(t, client, context.Background(), srv.URL+"/upload", strings.NewReader("ab"))
+	if resp.StatusCode != http.StatusOK {
+		t.Errorf("status = %d, want %d", resp.StatusCode, http.StatusOK)
+	}
+	if got := calls.Load(); got != 0 {
+		t.Errorf("effect calls after short body = %d, want 0", got)
+	}
+}


ffumero2003 added 22 commits October 28, 2026 13:17

test(internal): add recording B2 wire server

9984f36

test(b2): use shared recorder for CORS rule name

7a6cfc9

test(internal): check recording server response closes

99f64a0

test(b2): retain CORS rule count assertion

ccc6d55

test(internal): reproduce shared JSON map race

17d361b

fix(internal): isolate recorded JSON maps

3f6f077

docs: direct wire tests to shared recorder

a733261

docs(intent): record wire-test query parameters

a69a11a

test(internal): record wire-test query parameters

8fc8cf9

fix(internal): keep request data out of the unscripted response

b61fcd8

test(internal): verify recording server cleanup

57d42fa

fix(internal): set recording response security headers

e2d5726

docs(intent): plan credential-free tests for live-only calls (#203)

a9748f3

docs(intent): correct R8 to the shared-upload-token refusal the live …

e287c78

…test checks (#203)

test(transport): pin Stall context cancellation

0407c68

Assert that Stall returns before its duration when the request context ends. Align R5 with the separate ListKeys capabilities work in #220.

test(internal): reproduce recording server review edge cases

0791767

refactor(internal): share the recorded JSON body decode

6c6e654

serve and copyRequests both decoded a request body into a JSON map. Share one decodeJSON helper so the two paths cannot drift; a body that is not a JSON object still decodes to nil. The same change was reviewed on #211.

Merge remote-tracking branch 'origin/test-issue-191-shared-recording-…

c98ec4d

…server' into test-issue-203-credential-free-live-calls

ffumero2003 added this to the 0.10.0 milestone Oct 29, 2026

ffumero2003 added the skip-changelog No changelog entry needed; skips the changelog check label Oct 29, 2026

ffumero2003 requested a review from goanpeca as a code owner October 29, 2026 19:46

ffumero2003 self-assigned this Oct 29, 2026

ffumero2003 requested a review from sophiecarreras as a code owner October 29, 2026 19:46

ffumero2003 requested a review from david-santacruz-backblaze October 29, 2026 19:46

Base automatically changed from test-issue-191-shared-recording-server to main October 29, 2026 21:22

Merge remote-tracking branch 'origin/main' into test-issue-203-creden…

3b58143

…tial-free-live-calls

ffumero2003 added 2 commits October 29, 2026 16:48

Merge remote-tracking branch 'origin/main' into test-issue-203-creden…

5873ca7

…tial-free-live-calls

test: contrast newest and older versions in Reveal and pin AfterNByte…

a3268c2

…s on short bodies Script newest-first and older versions for Reveal, and ensure AfterNBytes does not trigger when a request body ends before its threshold. Part of #203

goanpeca requested a balanced review from Copilot October 29, 2026 23:10

Copilot started reviewing on behalf of goanpeca October 29, 2026 23:11

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

Navigation Menu

Repository navigation

test: add credential-free tests for calls only covered by live tests - #231

test: add credential-free tests for calls only covered by live tests#231
ffumero2003 wants to merge 25 commits into
mainfrom
test-issue-203-credential-free-live-calls

ffumero2003 commented Oct 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ffumero2003 commented Oct 29, 2026

Context

Changes

Split out or left out

Verification

Notes for reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants