Repository navigation
Add per-seed candidate selection before final output filtering - #290
Merged
Merged
Conversation
Member
|
thanks, please extend: incorporate into "gui"
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-seed diversity needs candidate selection before global ranking; filtering final tracebacks loses some seeds' best sites. This implements
--outNumberPerSeed=Kusing the maintainer's decisions in #288.Fixes #285. Supersedes the documentation checkpoint in #288.
--outPerRegionresets quotas per region combination.--noSeed, ignore the option for evaluation, and accept parameter files and values in [0,1000].Zall, trackers and actual-pair probabilities retain their ordinary prediction semantics.Validation: GCC 14 / ViennaRNA 2.7.2 release and debug
make tests -j2both passed 9/9 suites. The API suite passed 123 cases (529,850 release / 529,851 debug assertions), including exhaustive chain enumeration, noLP and cropped-coordinate oracles, anchor callback comparisons across the existing theory/random fixtures, heuristic/bulged ensembles and retained traceback energies. CLI regressions cover the mode matrix, explicit zero, invalid values, parameter files, evaluation, regions/windows, thread determinism, final restrictions, unchanged trackers and byte-identical probability files. Installation, a linked/running pkg-config consumer, five affected public headers compiled independently, andgit diff --checkalso passed.Out-of-tree validation used the source
src/include path, the generated source-sideIntaRNA.pcexpected by current build rules, and unchanged CLI fixtures copied into each build'stests/data/; no expected outputs were regenerated.Tradeoff: enabling this option runs the selected MFE predictor once per admitted seed, plus one ordinary pass when statistics/trackers are needed. Runtime can increase substantially; retained candidate storage is bounded by K sites per seed. Model P uses its existing anchor decomposition directly, including its canonical ownership of nested explicit seeds and the existing legacy bulged-mode limitations. Custom MFE predictor subclasses can override the per-seed factory hook; incompatible inherited factories fail explicitly instead of silently dropping custom recurrence behavior.