Repository navigation
Fix master WASM browser build after example update - #306
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cause
The intentionally replaced GUI example payloads merged in #287, but the real-browser test still expected the original short query immediately after clicking an example. This caused the master WebAssembly workflow to fail before exercising the rest of the interface.
Validation
npm test --prefix gui(25 tests passed)scripts/wasm/test-browser.py ...with staged current GUI and a real WASM engine in Chromiumscripts/wasm/test-browser.py ... --browser firefoxwith the same staged sitegit diff --check