Skip to content

Dock view controls on the right and guard manual-position actions - #114

Open
Alexander-Mitrofanov wants to merge 3 commits into
mainfrom
feature/view-controls-panel
Open

Alexander-Mitrofanov wants to merge 3 commits into
mainfrom
feature/view-controls-panel

Conversation

@Alexander-Mitrofanov

@Alexander-Mitrofanov Alexander-Mitrofanov commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Rotation, cropping, and manual-position controls now live in a View controls overlay on the canvas’s right edge. The drawer starts open, folds through its named toggle, and closes when the user clicks or begins dragging in the visualization. Opening and closing it leaves the canvas and surrounding page geometry unchanged.

Release now requires both Force layout and selected nodes. Its disabled state explains the requirement, and the action itself is guarded against calls in static mode. Reset and Undo remain available for manual positioning in static layouts.

The change includes responsive drawer layout, accessible expanded state and keyboard focus, updated documentation, and behavior regressions for the review requests.

Validation

  • 46 unit suites / 537 tests.
  • Architecture, installed package, native/standalone browser contracts, full Chromium and Firefox UI, documentation, and all five visual-fixture checks.
  • A fresh 12-screenshot matrix covers the open drawer, automatic close, stable canvas geometry, keyboard focus, static Release disabled, Force-layout Release enabled, and 640 × 480 rendering-only layout.
  • Visually inspected those interaction states; no page, console, local HTTP, or request errors in the dedicated browser scenarios.

Integration and merge order

The contextual video work in #113 incorporates this exact branch, including automatic closing and the Force-layout guard. Its 19 videos are refreshed against the combined interface.

Merge #113 into this branch first, then merge #114 into main. This order was simulated with both normal and squash merges and produces a clean combined tree. Squash-merging #114 first and then retargeting the old video history would reintroduce conflicts in the viewer component and guide; the stated order avoids them.

@martin-raden

Copy link
Copy Markdown
Member

@Alexander-Mitrofanov

thanks, please revise:

  • automatically hide "visualization controls" when clicking into the visualization area
  • enable "Release" button only in Force field mode (since otherwise without functionality/use)

@Alexander-Mitrofanov Alexander-Mitrofanov changed the title Move view controls into collapsible left panel Dock view controls on the right and guard manual-position actions Oct 31, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants