Repository navigation
Dock view controls on the right and guard manual-position actions - #114
Open
Alexander-Mitrofanov wants to merge 3 commits into
Open
Alexander-Mitrofanov wants to merge 3 commits into
Alexander-Mitrofanov wants to merge 3 commits into
Conversation
Member
|
thanks, please revise:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotation, cropping, and manual-position controls now live in a View controls overlay on the canvas’s right edge. The drawer starts open, folds through its named toggle, and closes when the user clicks or begins dragging in the visualization. Opening and closing it leaves the canvas and surrounding page geometry unchanged.
Release now requires both Force layout and selected nodes. Its disabled state explains the requirement, and the action itself is guarded against calls in static mode. Reset and Undo remain available for manual positioning in static layouts.
The change includes responsive drawer layout, accessible expanded state and keyboard focus, updated documentation, and behavior regressions for the review requests.
Validation
Integration and merge order
The contextual video work in #113 incorporates this exact branch, including automatic closing and the Force-layout guard. Its 19 videos are refreshed against the combined interface.
Merge #113 into this branch first, then merge #114 into
main. This order was simulated with both normal and squash merges and produces a clean combined tree. Squash-merging #114 first and then retargeting the old video history would reintroduce conflicts in the viewer component and guide; the stated order avoids them.