Skip to content

cli: Remove unreachable recovery and search paths - #105

Merged
BenWestgate merged 1 commit into
reviewability-v1from
codex/remove-unreachable-v1-branches
Oct 24, 2026
Merged

BenWestgate merged 1 commit into
reviewability-v1from
codex/remove-unreachable-v1-branches

Conversation

@BenWestgate

@BenWestgate BenWestgate commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Restore the focused cleanup review boundary after the historical #98 cleanup was absorbed into later stack work.

The PR is one squashed behavior-preserving cleanup commit:

  • remove the unused _correction_plan primary/reduced/timed state and _search_many(reduced=...) argument;
  • pass the already-type-checked share list directly to recover_secret() instead of filtering it a second time.

No correction scheduling, capture accounting, wallet behavior, or public input validation changes.

Review shape

Current head 9ea48de is stacked directly on current reviewability-v1 after #57 was merged. The branch now records one squashed commit authored by BenWestgate; the earlier agent-authored replay is no longer the live head.

The production-size gate remains the maintainer-authorized <5200.

Validation

Exact-head Python-package run 37479416800 completed successfully. The composed refreshed stack through #95 also passed all 941 tests normally and under python -O, Ruff check/format, mypy, correction-constant verification, all 57 frozen differential correction cases, and git diff --check.

A fresh Codex review has been requested for 9ea48de; the prior ACK covered the mechanically equivalent pre-rewrite head and all inline threads are resolved.

Human review/integration order is #105 → #99 → #80 → #81 → #95.

Refs #46 and #98.

@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted release-gate re-review performed at the maintainer's request and disclosed per docs/developer/AI_POLICY.md.

ACK d886238.

This is the same two-commit cleanup previously reviewed as #98, replayed directly on refreshed #57. Stable patch-ids match #98 exactly. The changes only remove provably redundant correction-plan state and the already-type-checked share filter; correction scheduling, capture accounting, wallet behavior, and public input validation are unchanged.

Current-base verification: 101 focused CLI/correction tests passed, and the installed source is 5,179 logical lines under the authorized <5200 cap. No correctness blocker found.

@BenWestgate BenWestgate added cli Command-line interface behavior. correction Correction engine and correction UX. gate: adversarial review Resolve, merge, or explicitly defer before the next full adversarial review. labels Oct 1, 2026
@BenWestgate
BenWestgate force-pushed the codex/remove-unreachable-v1-branches branch from d886238 to 52c23b3 Compare October 1, 2026 22:12

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head release-gate re-review: ACK 52c23b3. The two-commit cleanup removes only redundant correction-plan state and a share filter after the all-Share type check; no correction scheduling, capture accounting, wallet behavior, or public validation changes. On the full refreshed restore stack through #95, 935 tests pass normally and under python -O; Ruff, format, strict mypy, correction constants, all 57 frozen differential cases, and the production-size test pass. No code blocker found. Both commits are agent-authored and still require responsible-human rewrite/squash before integration.

@BenWestgate
BenWestgate force-pushed the codex/remove-unreachable-v1-branches branch from 52c23b3 to 361feb7 Compare October 2, 2026 08:58

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex current-head re-review: ACK 361feb7.

The current diff is still the narrow behavior-preserving cleanup: _correction_plan() returns only the target lengths it actually uses, _search_many() drops an unread reduced parameter, and recovery passes the already-validated all-Share list directly. No scheduling, capture accounting, wallet behavior, or public validation changes are introduced. There are no inline review threads, and exact-head Python-package run 660 succeeded.

No code blocker found. The two agent-authored commits still require responsible-human rewrite/squash under repository policy before integration.

BenWestgate added a commit that referenced this pull request Oct 4, 2026
Temporary stack refresh: bring the reviewed #105 cleanup into #99's feature branch so the PR head and CI represent the intended combined tree. Human integration will rewrite/squash agent-authored history under repository policy.
BenWestgate added a commit that referenced this pull request Oct 4, 2026
Temporary stack refresh: bring the reviewed #105 cleanup into #100's feature branch so the PR head and CI represent the intended combined tree. Human integration will rewrite/squash agent-authored history under repository policy.
BenWestgate added a commit that referenced this pull request Oct 4, 2026
Temporary stack refresh: bring the reviewed #105 cleanup into #101's feature branch so the PR head and CI represent the intended combined tree. Human integration will rewrite/squash agent-authored history under repository policy.

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex current-head review at 361feb7: no findings. This removes redundant correction-plan state and an unnecessary runtime share filter without changing the search envelope or validation boundary.

@BenWestgate
BenWestgate force-pushed the codex/remove-unreachable-v1-branches branch from 361feb7 to 03b0f8a Compare October 6, 2026 07:26

Copy link
Copy Markdown
Owner Author

@codex review

Current head was mechanically restacked onto the refreshed audit stack after #57's documentation-only follow-up. Please review this exact head for correctness/regressions; the composed stack passes 941 tests normally and under python -O, Ruff, mypy, correction constants, 57 frozen differential cases, and git diff --check locally.

@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted current-head review, posted at the maintainer's request.

ACK 03b0f8a. This is the same narrow behavior-preserving cleanup mechanically restacked on refreshed #57; the correction search envelope and validation boundaries are unchanged. Exact-head Python-package CI passes. No findings.

Copy link
Copy Markdown
Owner Author

@codex review

Please review current head 03b0f8a541 only. This is the final current-head audit check before human review; do not reopen superseded design debates unless there is a correctness, security, or release-blocking issue.

@chatgpt-codex-connector

This comment has been minimized.

Base automatically changed from 30-recorded-fingerprint-gate to reviewability-v1 October 6, 2026 14:09
Drop correction-plan state that no caller or search path reads, remove the corresponding unused `_search_many()` parameter, and pass the already-validated all-Share recovery list directly.

This is behavior-preserving cleanup only: correction scheduling, capture accounting, wallet behavior, and public validation remain unchanged.
@BenWestgate
BenWestgate force-pushed the codex/remove-unreachable-v1-branches branch from 03b0f8a to 9ea48de Compare October 6, 2026 14:29

Copy link
Copy Markdown
Owner Author

@codex review

Please review the current head 9ea48de only. This is a responsible-human rewrite of the previously reviewed behavior-preserving cleanup; confirm the rewrite did not change the correction/search or recovery contracts.

@chatgpt-codex-connector

This comment has been minimized.

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted current-head review: ACK 9ea48de. The removed correction-plan state was constant at every live call site (primary == all targets, reduced == empty, timed search enabled), so passing the targets directly preserves the search envelope. The recovery cast follows an explicit all(isinstance(..., Share)) guard and removes only the redundant second filter. Exact-head Python-package CI is green and there are no unresolved review threads. No correctness or release blocker found.

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T23:04:21.037711Z 9ea48de Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 9ea48de7ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenWestgate
BenWestgate added this pull request to stack #170 October 24, 2026 04:00

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BenWestgate
BenWestgate merged commit aa506bc into reviewability-v1 Oct 24, 2026
25 checks passed
@BenWestgate
BenWestgate deleted the codex/remove-unreachable-v1-branches branch October 24, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Command-line interface behavior. correction Correction engine and correction UX. gate: adversarial review Resolve, merge, or explicitly defer before the next full adversarial review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant