Repository navigation
library: Share card transcription alignment - #171
Draft
BenWestgate wants to merge 2 commits into
Draft
BenWestgate wants to merge 2 commits into
BenWestgate wants to merge 2 commits into
Conversation
Move the existing CLI alignment into a toolkit-free library module so the graphical interface can reuse the same grouping and tie-breaking rules. Return only entered characters; comparison ignores whitespace and ASCII case without treating Unicode lookalikes as printed card symbols. Exercise alignment with external strings, invalid characters, leading matches, and a property that alignment never completes the transcription. Existing CLI confirmation tests use the shared helper. refs #109
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Aligning a read-back costs time quadratic in its length: about a minute for 1,024 characters against one card, which froze the GUI. Text more than twice the card's length cannot be a careful copy, so mark every group wrong without aligning it. The CLI and GUI both get the bound. Claude-Session: https://claude.ai/code/session_018HrKoywz6PT9c91jvKou7Q
BenWestgate
added a commit
that referenced
this pull request
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the CLI's existing card-alignment code into a toolkit-free module for the GUI to reuse. Preserve entered characters and ASCII-only case normalization.
37058faalso skips alignment for input over twice the card's length and marks every group wrong. Alignment is quadratic, and 1,024 characters took about a minute against one card, which froze the GUI. The CLI gets the same bound.Based on #118; extracted from #109. Ruff and the confirmation and CLI tests (256) pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_018HrKoywz6PT9c91jvKou7Q