Repository navigation
errors: Remove unused parent exceptions - #175
BenWestgate wants to merge 1 commit into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Nothing raised or caught either class. Their children now derive from CodexError directly, so each failure names its specific reason. Claude-Session: https://claude.ai/code/session_01XGMpowzJwwgyHMEd63ijDe
1c9c77a to
13b8a4e
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| InvalidShareIndex = _error("InvalidShareIndex", CodexError, "The share index conflicts with its header.") | ||
|
|
||
| InvalidPadding = _error("InvalidPadding", CodexError, "The discarded payload padding is invalid.") | ||
| InvalidBip39Checksum = _error("InvalidBip39Checksum", CodexError, "The BIP39 checksum is invalid.") |
There was a problem hiding this comment.
we're removing the BIP39 profile in another PR, so this doesn't belong in this library anymore.
There was a problem hiding this comment.
Agreed for the BIP39-removal PR. profiles/bip39.py still imports and raises InvalidBip39Checksum at this head; deleting it here would break the current profile and expand this PR's scope. Remove both together in that PR. (AI-assisted response.)
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted static review. ACK 13b8a4e. Removing the unused parent exceptions leaves specific exceptions under CodexError. Keep InvalidBip39Checksum until the separate BIP39 profile removal; it is still raised by the current profile. Current-head CI is queued.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Remove the unused InvalidHeader and InvalidPayload parent exceptions. Keep specific failure types under CodexError.
Extracted from #146; based on #174. 182 focused API, parsing, profile and sharing tests pass.