Repository navigation
generation: Share card alignment results - #182
BenWestgate wants to merge 1 commit into
Conversation
The CLI kept its own edit-distance group aligner and then let the ceremony compare the text again positionally, so a dropped character marked every later group in the GUI. ConfirmationResult now carries the shift-aware mismatched groups and the entered text split per group; the CLI uses that result and keeps only its region-retry prompt. Claude-Session: https://claude.ai/code/session_01XGMpowzJwwgyHMEd63ijDe
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fc8fa4402
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| accepted: bool | ||
| mismatched_groups: tuple[int, ...] = () | ||
| entered_groups: tuple[str, ...] = () |
There was a problem hiding this comment.
When a caller prints or logs the result of CreationCeremony.confirm(), the dataclass-generated repr() and str() now expose every entered group, including the complete valid share on successful confirmation. Previously this public result contained only acceptance status and group indices. This bypasses the project's redacted artifact representations and violates the mandatory security contract keeping secrets out of logs and ordinary output. Mark entered_groups with repr=False or provide a redacted representation while retaining explicit access for presentation.
AGENTS.md reference: AGENTS.md:L70-L72
Useful? React with 👍 / 👎.
Return shift-aware entered groups and mismatches from ConfirmationResult so clients can share comparison logic.
Extracted from #146; based on #181. 41 generation tests pass.