Repository navigation
core: Remove Bails identifier heuristics - #186
Draft
BenWestgate wants to merge 1 commit into
Draft
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
identifier_origin and identifier_note recognised identifiers made by Bails' seed-digest rules. That belongs in Bails. Restoring an unshared backup without a wallet record still shows the master fingerprint, the warning, and whether the identifier matches the fingerprint as codex32 makes it for new unshared backups. Claude-Session: https://claude.ai/code/session_01XGMpowzJwwgyHMEd63ijDe
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
BenWestgate
commented
Oct 24, 2026
| ) | ||
| else: | ||
| _print( | ||
| "The backup identifier does not match this fingerprint. New unshared codex32 backups " |
Owner
Author
There was a problem hiding this comment.
An unshared secret may use a custom identifier. A nonmatch is inconclusive; please say so instead of implying the card is wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Bails-specific seed-digest identifier heuristics from python-codex32. Explain the limited evidence provided by a fingerprint-derived identifier match.
Extracted from #146; based on #185. 42 Bitcoin Core adapter tests pass. Bails integration is tracked in BenWestgate/Bails#351.