Repository navigation
share: Show fingerprint after threshold - #193
Conversation
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
looks good, mighty small change for a useful safety feature when generating extra shares.
|
@FractalEncrypt thanks for the request/suggestion. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BenWestgate
added
enhancement
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted code review, at maintainer request. ACK 3e7b330: inspected the two-file diff. Fingerprint is shown only after successful share derivation on interactive, non-plain output; pipes remain unchanged. CI was queued at review time.
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Show the recovered master fingerprint on interactive
ms32 shareoutput only after a threshold-capable basis has been validated.--plainand redirected output stay unchanged.Replaces the unreviewable stacked diff in #100 with the same focused behavior on current
reviewability-v1: two files, +11/−5 lines. The new code and test blobs are byte-identical to the locally validated versions.Validation: 243 CLI tests; Ruff lint and format checks pass. Exact-head CI and human review remain required. No force-push or unrelated history rewrite.