Repository navigation
cli: Write several additional cards per run - #198
BenWestgate wants to merge 1 commit into
Conversation
Read the input cards once for a batch of requested indices. Entered indices produce copies, including copy-only runs below threshold; new indices still require a complete validated basis. Resolve every output before printing any card, and confirm each interactive copy. Extract the remaining CLI behavior from the oversized original PR. The creation-copy change is reviewed separately in PR 197. Retain the current library contract and avoid carrying old wallet changes. Validation: 292 CLI and generation tests pass normally and with Python -O; Ruff lint/format, mypy and diff checks pass. refs #103 refs #87
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted security self-review at 5c80534: no findings across all five changed files. Copy-only input cannot trigger sub-threshold derivation; outputs resolve before printing and each interactive copy is confirmed. 292 tests pass normally and optimized; Ruff/mypy pass. I prepared this split, so this is not an independent approval.
ms32 share cdfreads existing cards once, resolves the requested outputs before printing any, then confirms each card. Entered indices make copies; copy-only runs need no threshold. New indices still require a complete validated basis.Post-v1 split of #103, stacked on #197. This PR contains only the CLI/input changes and their tests/docs (+77/−47 across five files), without the older wallet changes.
Validation: 292 CLI/generation tests pass normally and under Python
-O; Ruff lint/format, mypy and whitespace checks pass. Security review is still required.Refs #87.