Repository navigation
generation: Require explicit entropy source - #200
BenWestgate wants to merge 4 commits into
Conversation
Route every random draw through a caller-provided entropy function and validate its byte count. Keep current CLI behavior by passing the OS CSPRNG explicitly, so the Core-backed source can be reviewed separately. Update generation tests, the installed-wheel smoke test, and API documentation for the new boundary.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted current-head static review.
ACK 63c50a6: every new draw requires a caller-supplied entropy source; returned byte count/type is checked. Five-bit symbol generation remains uniform, and index selection rejects modulo bias. The confirmation gate is unchanged. Exact-head Python CI passed. Review the stacked Core integration separately.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63c50a6e1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Make every generation draw come from a caller-supplied
entropy(length)source and validate the returned byte count. The CLI passes the OS CSPRNG in this prerequisite, preserving existing behavior; #145 replaces that source with Bitcoin Core.Validation: 298 generation/public-API/CLI tests pass;
git diff --checkpasses. Changes to generation still require security review.