Repository navigation
tools: Verify Core entropy against regtest - #202
BenWestgate wants to merge 1 commit into
Conversation
Add a standalone Linux regtest check for repeated CoreEntropy draws, real signal interruptions, disk-fallback warnings, and temporary-wallet cleanup. Run it in the pinned Bitcoin Core fixture workflow and document the verification surface.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted review. ACK 10f2c9b (static). Focused regtest coverage for repeated entropy draws, signal interruption, disk fallback, wallet cleanup, and secret leakage. The pinned Bitcoin Core CI job passed, including the new entropy step; I did not independently run Core locally.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add the standalone Linux regtest harness for repeated
CoreEntropydraws, real signal interruptions, disk-fallback warnings and temporary-wallet cleanup, and run it in the pinned Core fixture workflow.The harness is unchanged from the previous #145 head, where it passed 22/22 against Core 32.0rc4. On this split,
py_compile, Ruff andgit diff --checkpass.Stacked on #201.