Repository navigation
create: Finish cleanup after interruption - #203
BenWestgate wants to merge 2 commits into
Conversation
Ctrl-C during the folder delete or the macOS RAM disk detach escaped before the other step ran and before the user was told what was left. Both steps now catch it like the RPC steps do, so cleanup finishes and anything still on disk is named in the error that stops creation. Claude-Session: https://claude.ai/code/session_01T233rKgZqE5wzDm3EVTHL1
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted review: ACK 3d5f877. Reviewed both files and the entropy/CLI cleanup path; security diff scan found no reportable issue. 307 Core/CLI tests and 10 optimized-mode entropy tests pass. Native macOS detach was simulated; live Core was not rerun locally.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Ctrl-C, SIGHUP or SIGTERM during wallet-folder deletion or macOS RAM-disk detach used to escape before the other cleanup step ran and before the user was told what remained.
Catch interruption in both steps so cleanup finishes and any remaining resource is named in the creation-stopping error. Two tests interrupt each cleanup step.
Stacked on #201.