Repository navigation
gui: Apply Tails field-test feedback - #77
BenWestgate wants to merge 9 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated release-gate review, posted at the maintainer's request.
Code ACK 2caf9c8, with one manual qualification item remaining before integration: verify the finished wallet-identity screen at the supported Tails guest resolution for #74.
- #71 is copy-only: the preset behavior is unchanged and only “(recommended)” is removed.
- #72 keeps uppercase four-character groups and existing per-group highlighting; the FlowBox may use the full row and wraps only when width requires it instead of forcing four columns.
- #73 changes operator guidance only. Passphrase transport, clearing, wallet creation, and secret-handling code are unchanged.
- #74 retains every identity field and replaces the vertically heavy preference rows with a selectable two-column grid; no release-specific window geometry is introduced.
- #66 wallet polling/selection behavior is untouched.
The two curly-quote literal-vs-escape changes in this one-file diff are source-spelling-only and have identical runtime text; they are not a correctness blocker.
Automatic Codex review did not run because the account review-usage limit was reached. Do not spend another review request on this head; use this code review plus the normal CI, then do the Tails visual fit check.
BenWestgate
left a comment
There was a problem hiding this comment.
Updated release-gate review for current head fc648a3.
Code ACK. The second commit is mechanical review-budget cleanup only: it removes the module docstring and shortens two equivalent GTK constructor/call layouts in app.py; runtime behavior is unchanged. The resulting source count should be 2,048 logical GUI lines, retaining the enforced <2050 budget rather than raising it.
The only non-CI qualification still required is the manual Tails guest-resolution fit check for #74. No further automated Codex review request is warranted on this head.
BenWestgate
left a comment
There was a problem hiding this comment.
Updated release-gate review for current head 4edeb06.
Code ACK, subject to the already-recorded manual Tails fit check for #74.
The two CI follow-ups are mechanical and justified by the failures they expose: app.py is now exactly Ruff's requested formatting while the GUI stays below the unchanged <2050 review budget, and test_gui_boundaries.py now decodes Python source explicitly as UTF-8 instead of relying on the Windows locale. The latter is the correct source-file contract and removes the cp1252-only failures without changing production behavior.
No further automated Codex review request is warranted on this head; use the current CI plus the manual Tails fit check.
BenWestgate
left a comment
There was a problem hiding this comment.
Updated release-gate review for current head 72b5aae.
Code ACK, subject only to the already-recorded manual Tails fit check for #74. The only change since the prior reviewed head removes the non-runtime main() docstring after CI measured the GUI at exactly 2,050 logical lines; current production count is therefore 2,049 under the unchanged <2050 gate. No semantics changed.
BenWestgate
left a comment
There was a problem hiding this comment.
Release-gate ACK 72b5aae for automated/code review. The exact-head Python-package run 464 completed successfully across the six matrix jobs, and the current head remains within the unchanged GUI review budget. No automated code blocker remains.
The only remaining acceptance item is the already-recorded manual Tails guest-resolution check for the wallet-identity fit (#74); #78 has the analogous manual home-height check. Do not trigger another automated review round.
|
Agent release-gate review at exact head |
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review (Codex), posted at the maintainer's request.
ACK 72b5aae. No correctness or security issues found in the Tails field-test UI changes.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72b5aae625
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
cACK. I will review when the robots are satisfied with it. Please squash into atomic commit(s) according to contributing.md in the meantime. |
Wrap long wallet names on the finished record and update the GUI walkthrough to check responsive reading order at both widths.
Follow the repository's Ruff RUF007 rule in the responsive GUI walkthrough.
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted code review at the maintainer’s request. Code ACK b6b28dc: responsive card order and wallet-name wrapping address both peer findings. All six exact-head Python matrix jobs passed. Remaining: squash fixups and check wallet-record fit on supported Tails; neither changes the code findings.
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Let the home page scroller contribute its natural height to the initial window size. Other workflow pages still scroll without requesting their full height. refs #75
Addresses Tails GUI field-test issues #71–#74:
No change to parsing, card data, wallet import, passphrase transport, or wallet polling.
Validation:
b6b28dcfixes the responsive walkthrough and wallet-name wrapping; GitHub Actions run 40085747425 passed all six Python 3.12/3.13 jobs across Linux, macOS and Windows. The supported-Tails guest-resolution fit check remains outstanding.Closes #71, #72, #73, #74. AI-assisted changes; human review required.